Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammar of the notice that indicates a new release is available #11529

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Fix grammar of the notice that indicates a new release is available #11529

merged 4 commits into from
Jan 31, 2023

Conversation

mdmintz
Copy link
Contributor

@mdmintz mdmintz commented Oct 19, 2022

Fix grammar of the notice that indicates a new release is available

Change A new release of pip available: to A new release of pip is available:

(Assuming this is a trivial change that does not require a news entry.)

@uranusjr
Copy link
Member

Could you add a news fragment please? The macOS test failures seem to be unrelated, we need to fix our test setup it seems.

@mdmintz
Copy link
Contributor Author

mdmintz commented Oct 19, 2022

@uranusjr I added the news fragment.

@mdmintz
Copy link
Contributor Author

mdmintz commented Oct 19, 2022

Updated with the news fragment in the correct location

@mdmintz
Copy link
Contributor Author

mdmintz commented Nov 2, 2022

@uranusjr Now that #11532 is merged, which should fix the tests, can you trigger a rerun of the tests?

@mdmintz
Copy link
Contributor Author

mdmintz commented Jan 31, 2023

Hello @uranusjr,
Just checking to see if this PR was forgotten.
The latest notice still has the old working.

@pradyunsg pradyunsg merged commit 2c09e9c into pypa:main Jan 31, 2023
@pradyunsg
Copy link
Member

This will be in the next release (not sure if we're going to do a bug fix).

Note that the grammar fix won't show up until the pip version you're upgrading from matches the one this releases in.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdmintz @uranusjr @pradyunsg